From: Johannes Schindelin Date: Wed, 19 Jun 2019 11:17:54 GMT Subject: Re: [PATCH 03/17] cache-tree.c: avoid reusing the DEBUG constant Message-ID: In-Reply-To: Hi Carlo, On Tue, 18 Jun 2019, Carlo Arenas wrote: > shouldn't this also be a problem with builtin/blame.c? Sharp eyes! It does not *really* matter as much here, as that file defines that `DEBUG` constant if it has not yet been defined, but yes, it assumes that *if* it is defined, then it is set to `1`. Which is the case, but it is fragile. I changed it locally already, and it will be part of the next iteration. Thanks, Johannes