Re: [PATCH 0/3] Close commit-graph before calling 'gc'

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 20, 2019, 10:13 UTC
Message-ID: <nycvar.QRO.7.76.6.1905201204390.46@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqk1en19pp.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Sun, 19 May 2019, Junio C Hamano wrote:

Show 9 quoted lines

> "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > This series adds close_commit_graph() to close_all_packs() and then renames
> > close_all_packs() to close_object_store(). This name is more descriptive of
> > its larger purpose.
>
> OK.  Somebody needs to go though all the existing callers of
> close_all_packs() to see if the above claim is true (unless you
> haven't done so, that is), but I really like the general direction.

I tried to provide that in my review of 3/3.

Please note that these patches are most relevant for Windows, where renames and deletes fail when any process has an open handle to the file(s) in question.

Ciao, Dscho

P.S.: Now that I think of it, if we close the object store, that's probably also a time when we want to release the loose object cache.