Re: [PATCH 0/3] Close commit-graph before calling 'gc'

From: Derrick Stolee <stolee@gmail.com>
Date: May 20, 2019, 11:05 UTC
Message-ID: <42c3857c-ef26-a05d-e2d8-30a450199fe8@gmail.com>
In-Reply-To: <xmqqk1en19pp.fsf@gitster-ct.c.googlers.com>

On 5/18/2019 10:04 PM, Junio C Hamano wrote:

Show 9 quoted lines

> "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
>> This series adds close_commit_graph() to close_all_packs() and then renames 
>> close_all_packs() to close_object_store(). This name is more descriptive of
>> its larger purpose.
> 
> OK.  Somebody needs to go though all the existing callers of
> close_all_packs() to see if the above claim is true (unless you
> haven't done so, that is), but I really like the general direction.

Here is a full inventory. Most of the context can be found simply by 'git grep -B 10 -A 10 close_object_store' but some cases need reading a helper function to know for sure.

About to call gc or repack:

* am
* clone
* fetch
* merge
* rebase
* receive-pack

Is about to delete packs or pack-garbage:

* gc
* repack

And in object.c, we are in the "raw_object_store_clear()" method.

Thanks, -Stolee