Re: [PATCH 1/1] cvsexportcommit: force crlf translation

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 8, 2019, 10:56 UTC
Message-ID: <nycvar.QRO.7.76.6.1905081248190.44@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqtve6lito.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Tue, 7 May 2019, Junio C Hamano wrote:

Show 12 quoted lines

> "Dustin Spicuzza via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > From: Dustin Spicuzza <dustin@virtualroadside.com>
> >
> > When using cvsnt + msys + git, it seems like the output of cvs status
> > had \r\n in it, and caused the command to fail.
>
> This is a bit under-explained in that it does not make it clear
> where the right place to fix would be.  From "X did Y which caused
> the command to fail", a possible right fix could be "so fix it by
> telling X not to do Y", but of course a patch to fix cvsnt won't
> come to this list ;-)

Right.

How about this:

	The offical CVS for Windows (called CVS NT) produces DOS line
	endings in its `cvs status` output. Let's teach our own
	`cvsexportcommit` command to handle that gracefully.

It is unlikely that anybody wants to spend time "fixing" this in CVS NT, even less likely that anybody would take that patch, and even if that was the case, there will still be plenty of CVS NT versions out there that `cvsexportcommit` cannot handle.

I think it would be best to just integrate this change in Git and be done with it. It's not like it adds a ton of maintenance burden there.

(BTW this was also my thinking when I accepted that patch into Git for Windows, and thereby accepted the responsibility of upstreaming it.)

Ciao, Dscho