git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/1] cvsexportcommit: force crlf translation

From
DGDustin Spicuzza via GitGitGadget <gitgitgadget@gmail.com>
Date
Apr 29, 2019, 21:58 UTC
Message-ID
<9b508af11be125ce5fd80c40c732dbcaf45067fb.1556575126.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.132.git.gitgitgadget@gmail.com>
From: Dustin Spicuzza <dustin@virtualroadside.com>

When using cvsnt + msys + git, it seems like the output of cvs status had \r\n in it, and caused the command to fail.

This fixes that.
Signed-off-by: Dustin Spicuzza <dustin@virtualroadside.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 git-cvsexportcommit.perl | 1 +
 1 file changed, 1 insertion(+)
diff --git a/git-cvsexportcommit.perl b/git-cvsexportcommit.perl
index d13f02da95..fc00d5946a 100755
--- a/git-cvsexportcommit.perl
+++ b/git-cvsexportcommit.perl
@@ -431,6 +431,7 @@ END
 sub safe_pipe_capture {
     my @output;
     if (my $pid = open my $child, '-|') {
+	binmode($child, ":crlf");
 	@output = (<$child>);
 	close $child or die join(' ',@_).": $! $?";
     } else {
-- 
gitgitgadget
Previous: Johannes Schindelin via GitGitGadgetNext: Junio C Hamano
Message 2 of 7 in “Fix cvsexportcommit with CR/LF line endings”
  1. 0/1 Fix cvsexportcommit with CR/LF line endingsJohannes Schindelin via GitGitGadget, Apr 29, 2019
  2. 1/1 cvsexportcommit: force crlf translationDustin Spicuzza via GitGitGadget, Apr 29, 2019
  3. Junio C HamanoMay 7, 2019
  4. Dustin SpicuzzaMay 7, 2019
  5. Junio C HamanoMay 7, 2019
  6. Johannes SchindelinMay 8, 2019
  7. Junio C HamanoMay 8, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.