Re: [PATCH 1/1] mingw: optionally disable side-band-64k for transport

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Apr 30, 2019, 22:33 UTC
Message-ID: <nycvar.QRO.7.76.6.1904301832500.45@tvgsbejvaqbjf.bet>
In-Reply-To: <b8e799e2-356d-2a03-faa4-2792ec1b171d@kdbg.org>

Hi Hannes,

On Tue, 30 Apr 2019, Johannes Sixt wrote:

Show 22 quoted lines

> Am 30.04.19 um 01:17 schrieb Johannes Schindelin:
> > On Mon, 29 Apr 2019, Eric Sunshine wrote:
> >> On Mon, Apr 29, 2019 at 6:04 PM Thomas Braun via GitGitGadget
> >>> diff --git a/Documentation/config/sendpack.txt b/Documentation/config/sendpack.txt
> >>> @@ -0,0 +1,5 @@
> >>> +sendpack.sideband::
> >>> +       Allows to disable the side-band-64k capability for send-pack even
> >>> +       when it is advertised by the server. Makes it possible to work
> >>> +       around a limitation in the git for windows implementation together
> >>> +       with the dump git protocol. Defaults to true.
> >>
> >> s/dump/dumb/
> >>
> >> For someone who hasn't read the commit message of this patch, "work
> >> around a limitation in ... git for windows" doesn't mean much. Perhaps
> >> this documentation could explain in more precise terms under what
> >> circumstances this option should be used?
> >
> > You're right, this is confusing, especially since Git for Windows 2.x does
> > not have that bug.
>
> If there is no bug, why do we need the patch?

I thought you of all people (building with the ancient MSys/MINGW toolchains) would benefit from it :-)

But if even you don't want it, I'll gladly drop it from Git for Windows' patches and be done with it.

Ciao, Dscho