Re: [PATCH 1/1] mingw: optionally disable side-band-64k for transport

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Apr 29, 2019, 22:10 UTC
Message-ID: <CAPig+cT1EP+HC5h4e0NGCu=1i6cZXPxERRgnnAdZJn+XeqpbFw@mail.gmail.com>
In-Reply-To: <31aa7bfcab834b753cc9f52fc9cc187f65e2d964.1556575475.git.gitgitgadget@gmail.com>

On Mon, Apr 29, 2019 at 6:04 PM Thomas Braun via GitGitGadget <gitgitgadget@gmail.com> wrote:

Show 5 quoted lines

> Since commit 0c499ea60f (send-pack: demultiplex a sideband stream with
> status data, 2010-02-05) the built-in send-pack uses the side-band-64k
> capability if advertised by the server.
>
> Unfortunately this breaks pushing over the dump git protocol if used

s/dump/dumb/

Show 17 quoted lines

> over a network connection when using MinGW (but *not* when using
> mingw-w64).
> [...]
> The new config option "sendpack.sideband" allows to override the
> side-band-64k capability of the server, and thus makes the dump git
> protocol work.
> [...]
> Signed-off-by: Thomas Braun <thomas.braun@byte-physics.de>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
> diff --git a/Documentation/config/sendpack.txt b/Documentation/config/sendpack.txt
> @@ -0,0 +1,5 @@
> +sendpack.sideband::
> +       Allows to disable the side-band-64k capability for send-pack even
> +       when it is advertised by the server. Makes it possible to work
> +       around a limitation in the git for windows implementation together
> +       with the dump git protocol. Defaults to true.

s/dump/dumb/

For someone who hasn't read the commit message of this patch, "work around a limitation in ... git for windows" doesn't mean much. Perhaps this documentation could explain in more precise terms under what circumstances this option should be used?