Re: [PATCH 1/1] credential: do not mask the username

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Apr 29, 2019, 23:06 UTC
Message-ID: <nycvar.QRO.7.76.6.1904291904560.45@tvgsbejvaqbjf.bet>
In-Reply-To: <CAPig+cSiv+4xh6bWDTggBiApywAmAx6eQLq+Dh116kO2+cf_kg@mail.gmail.com>

Hi Eric,

On Mon, 29 Apr 2019, Eric Sunshine wrote:

Show 13 quoted lines

> On Mon, Apr 29, 2019 at 6:06 PM Jarosław Honkis via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
> > When a user is asked for credentials there is no need to mask the
> > username, so the PROMPT_ASKPASS flag on calling credential_ask_one for
> > login is unnecessary.
> >
> > The `credential_ask_one()` function internally uses `git_prompt()` which
> > in case it is given the flag PROMPT_ASKPASS uses masked input method
> > instead of git_terminal_prompt, which does not mask user input.
> >
> > This fixes https://github.com/git-for-windows/git/issue/675
>
> This link is dead. Is there a more modern URL to which this can point?

Oops. I should have looked more carefully, right? It is missing an "s" at the end of "issues":

	https://github.com/git-for-windows/git/issues/675

Thanks, Dscho

> > Signed-off-by: Jarosław Honkis <yaras6@gmail.com>
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>
>