Re: [PATCH 1/1] credential: do not mask the username
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Apr 29, 2019, 22:12 UTC
- Message-ID
- <CAPig+cSiv+4xh6bWDTggBiApywAmAx6eQLq+Dh116kO2+cf_kg@mail.gmail.com>
- In-Reply-To
- <e459e487d3848ae1b7f37676bd9d2a2f9c967430.1556575570.git.gitgitgadget@gmail.com>
On Mon, Apr 29, 2019 at 6:06 PM Jarosław Honkis via GitGitGadget <gitgitgadget@gmail.com> wrote:
Show 9 quoted lines
> When a user is asked for credentials there is no need to mask the > username, so the PROMPT_ASKPASS flag on calling credential_ask_one for > login is unnecessary. > > The `credential_ask_one()` function internally uses `git_prompt()` which > in case it is given the flag PROMPT_ASKPASS uses masked input method > instead of git_terminal_prompt, which does not mask user input. > > This fixes https://github.com/git-for-windows/git/issue/675
This link is dead. Is there a more modern URL to which this can point?
> Signed-off-by: Jarosław Honkis <yaras6@gmail.com> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>