Re: [PATCH 8/8] tests: disallow the use of abbreviated options (by default)
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Apr 12, 2019, 08:59 UTC
- Message-ID
- <nycvar.QRO.7.76.6.1904121058400.41@tvgsbejvaqbjf.bet>
- In-Reply-To
- <87sgvabutb.fsf@evledraar.gmail.com>
Hi Ævar,
On Mon, 25 Mar 2019, Ævar Arnfjörð Bjarmason wrote:
Show 12 quoted lines
>
> On Mon, Mar 25 2019, Johannes Schindelin via GitGitGadget wrote:
>
> > +# Disallow the use of abbreviated options in the test suite by default
> > +test -n "$GIT_TEST_DISALLOW_ABBREVIATED_OPTIONS" || {
> > + GIT_TEST_DISALLOW_ABBREVIATED_OPTIONS=true
> > + export GIT_TEST_DISALLOW_ABBREVIATED_OPTIONS
> > +}
> > +
>
> Just using the if test ...\nthen\nfi long-form would be consistent with
> our usual style & the rest of this file.Yep, and we also use the `${...:+isset}` dance, so I imitated that, too.Thanks for reminding me that when in Rome, do as the Romans do, Dscho