Re: [PATCH 1/2] parse-options: allow for configuring option abbreviation

From: Duy Nguyen <pclouds@gmail.com>
Date: Mar 26, 2019, 07:13 UTC
Message-ID: <CACsJy8BpToq2VAzFo61dz7Hco42Sbka5qQm3ACn_6aejUxAKOg@mail.gmail.com>
In-Reply-To: <87lg12b13p.fsf@evledraar.gmail.com>

On Tue, Mar 26, 2019 at 1:29 PM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

> I don't see how a new "abbreviatedOptions" is plausibly going to crowd
> out anything else, sounds pretty unambiguous to me.

By crowded I mean a lot of configuration variables under "core"

Show 7 quoted lines

> By my count out of the the existing GIT_* variables in git.txt around
> 1/3 are already configurable via config, another 1/3 (all the GIT_TRACE
> stuff) is something we've wanted to have configurable in the past (but
> nobody's gotten around to writing patches for).
>
> I think it's fair to say that when we normally add user-configurable
> stuff we do it as config, not as new env vars.

I disagree that not every configuration knob has to be a configuration variable, especially when core.* more or less becomes a dictionary that you can't really read anymore (unless you know the key to look for). But I see you're dead set on adding config vars. Go ahead.

-- 
Duy