Re: [PATCH 0/1] Fix hang in t5562, introduced in v2.21.0-rc1

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 19, 2019, 14:09 UTC
Message-ID: <nycvar.QRO.7.76.6.1902191507380.41@tvgsbejvaqbjf.bet>
In-Reply-To: <20190218205725.GB3373@jessie.local>

Hi Max & Randall,

On Mon, 18 Feb 2019, Max Kirillov wrote:

Show 24 quoted lines

> On Mon, Feb 18, 2019 at 03:46:34PM -0500, Randall S. Becker wrote:
> > On February 18, 2019 15:41, Johannes Schindelin wrote:
> > > So could you try with this patch?
> > > 
> > > -- snipsnap --
> > > diff --git a/http-backend.c b/http-backend.c index d5cea0329a..7c1b4a2555
> > > 100644
> > > --- a/http-backend.c
> > > +++ b/http-backend.c
> > > @@ -427,6 +427,7 @@ static void inflate_request(const char *prog_name,
> > > int out, int buffer_input, ss
> > > 
> > >  done:
> > >  	git_inflate_end(&stream);
> > > +	close(0);
> > >  	close(out);
> > >  	free(full_request);
> > >  }
> > 
> > In isolation or with the other fixes associated with t5562? Or, which
> > baseline commit should I use? 8989e1950a or d92031209a or some other?
> 
> As far as I understand, it should be tried instead of 
> https://public-inbox.org/git/20181124093719.10705-1-max@max630.net/

Don't ask me which patches you need to try this with. I was just answering to the observation that the hangs happen in the gzip-encoding test cases, and this was my guess as to what is going wrong there. I have no idea whether other patches try to address the same thing, are obsoleted by this diff, or whatever, as I have not been able to pay attention to the Git mailing list in the past 5 days.

Ciao, Johannes