Re: [PATCH 1/1] tests: teach the test-tool to generate NUL bytes and use it

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 15, 2019, 14:59 UTC
Message-ID: <nycvar.QRO.7.76.6.1902151558080.45@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqimxm6msi.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Thu, 14 Feb 2019, Junio C Hamano wrote:

Show 19 quoted lines

> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
> 
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > In cc95bc2025 (t5562: replace /dev/zero with a pipe from
> > generate_zero_bytes, 2019-02-09), we replaced usage of /dev/zero (which
> > is not available on NonStop, apparently) by a Perl script snippet to
> > generate NUL bytes.
> >
> > Sadly, it does not seem to work on NonStop, as t5562 reportedly hangs.
> > ...
> > In the end, though, what counts is that this here change incidentally
> > fixes that hang (maybe also on NonStop?). Even more positively, it gets
> > rid of yet another unnecessary Perl invocation.
> 
> Thanks for a quick band-aid.
> 
> Will apply directly to 'master' so that we won't forget before -rc2.

Thank you, that will be good, as the builds still seem to fail. All of them.

> In the meantime, perhaps somebody who knows Perl interpreter's
> quirks well can tell us what's different between the obvious and
> simple C program and an equivalent in Perl to convince us why this
> is a good solution to the problem.

I would be *really* curious about that, too.

Ciao, Dscho