Re: [PATCH 2/3] http: add support for disabling SSL revocation checks in cURL

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 16, 2018, 12:25 UTC
Message-ID: <nycvar.QRO.7.76.6.1810161424390.4546@tvgsbejvaqbjf.bet>
In-Reply-To: <20181016063323.GA25933@sigill.intra.peff.net>

Hi Peff,

On Tue, 16 Oct 2018, Jeff King wrote:

Show 19 quoted lines

> On Tue, Oct 16, 2018 at 01:23:25PM +0900, Junio C Hamano wrote:
> 
> > > +#if LIBCURL_VERSION_NUM >= 0x072c00
> > > +		curl_easy_setopt(result, CURLOPT_SSL_OPTIONS, CURLSSLOPT_NO_REVOKE);
> > > +#else
> > > +		warning("CURLSSLOPT_NO_REVOKE not applied to curl SSL options because\n"
> > > +			"your curl version is too old (>= 7.44.0)");
> > > +#endif
> > 
> > That ">=" is hard to grok.  I think you meant it to be pronounced
> > "requries at least", but that is not a common reading.  People more
> > commonly pronounce it "is greater than or equal to".
> 
> This seemed oddly familiar:
> 
>   https://public-inbox.org/git/8da9d436-88b9-7959-dd9c-65bdd376bf54@mail.mipt.ru/
> 
> Since this one is clearly copied from there, it may be worth fixing the
> original.

Good memory. I just integrated the patch here. It was not signed off, but it is too obvious to be protected under copyright, so I re-did it, adding a nice commit message.

Ciao, Dscho