Re: [PATCH 2/3] http: add support for disabling SSL revocation checks in cURL

From: Jeff King <peff@peff.net>
Date: Oct 16, 2018, 06:33 UTC
Message-ID: <20181016063323.GA25933@sigill.intra.peff.net>
In-Reply-To: <xmqq1s8q34g2.fsf@gitster-ct.c.googlers.com>

On Tue, Oct 16, 2018 at 01:23:25PM +0900, Junio C Hamano wrote:

Show 10 quoted lines

> > +#if LIBCURL_VERSION_NUM >= 0x072c00
> > +		curl_easy_setopt(result, CURLOPT_SSL_OPTIONS, CURLSSLOPT_NO_REVOKE);
> > +#else
> > +		warning("CURLSSLOPT_NO_REVOKE not applied to curl SSL options because\n"
> > +			"your curl version is too old (>= 7.44.0)");
> > +#endif
> 
> That ">=" is hard to grok.  I think you meant it to be pronounced
> "requries at least", but that is not a common reading.  People more
> commonly pronounce it "is greater than or equal to".

This seemed oddly familiar:

  https://public-inbox.org/git/8da9d436-88b9-7959-dd9c-65bdd376bf54@mail.mipt.ru/

Since this one is clearly copied from there, it may be worth fixing the original.

-Peff