git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/4] Use oid_object_info() instead of read_object_file()

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 18, 2018, 12:13 UTC
Message-ID
<nycvar.QRO.7.76.6.1807181413200.71@tvgsbejvaqbjf.bet>
In-Reply-To
<CAL21BmmwRDwWc_4JmFKMA6ZYcx=A4biG+tmrBHPRNAxpSkt_NA@mail.gmail.com>
Hi Olga,
On Fri, 13 Jul 2018, Оля Тележная wrote:
Show 28 quoted lines
> 2018-07-09 11:27 GMT+03:00 Оля Тележная <olyatelezhnaya@gmail.com>:
> > Hello everyone,
> > This is my new attempt to start using oid_object_info_extended() in
> > ref-filter. You could look at previous one [1] [2] but it is not
> > necessary.
> >
> > The goal (still) is to improve performance by avoiding calling expensive
> > functions when we don't need the information they provide
> > or when we could get it by using a cheaper function.
> >
> > This patch is a middle step. In the end, I want to add new atoms
> > ("objectsize:disk" and "deltabase") and reuse ref-filter logic in
> > cat-file command.
> >
> > I also know about problems with memory leaks in ref-filter: that would
> > be my next task that I will work on. Since I did not generate any new
> > leaks in this patch (just use existing ones), I decided to put this
> > part on a review and fix leaks as a separate task.
> 
> UPDATES since v1:
> add init to eaten variable (thanks to Szeder Gabor, Johannes Schindelin)
> improve second commit message (thanks to Junio C Hamano)
> add static keyword (thanks to Ramsay Jones)
> 
> >
> > Thank you!
> >
> > [1] https://github.com/git/git/pull/493

Could you please populate the description of that PR so that SubmitGit picks it up as cover letter?

Thanks, Johannes

> > [2] https://public-inbox.org/git/010201637254c969-a346030e-0b75-41ad-8ef3-2ac7e04ba4fb-000000@eu-west-1.amazonses.com/
> 
Previous: Оля ТележнаяNext: Junio C Hamano
Message 5 of 6 in “Use oid_object_info() instead of read_object_file()”
  1. 0/4 Use oid_object_info() instead of read_object_file()Оля Тележная, Jul 9, 2018
  2. Junio C HamanoJul 9, 2018
  3. Johannes SchindelinJul 10, 2018
  4. Оля ТележнаяJul 13, 2018
  5. Johannes SchindelinJul 18, 2018
  6. Junio C HamanoJul 18, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.