Re: [PATCH 0/4] Use oid_object_info() instead of read_object_file()

From: Оля Тележная <olyatelezhnaya@gmail.com>
Date: Jul 13, 2018, 12:46 UTC
Message-ID: <CAL21BmmwRDwWc_4JmFKMA6ZYcx=A4biG+tmrBHPRNAxpSkt_NA@mail.gmail.com>
In-Reply-To: <CAL21BmkBohTOVdCO_ENVfzL28aRjoh1MCCF6750AQEYsc7L54w@mail.gmail.com>

2018-07-09 11:27 GMT+03:00 Оля Тележная <olyatelezhnaya@gmail.com>:

Show 17 quoted lines

> Hello everyone,
> This is my new attempt to start using oid_object_info_extended() in
> ref-filter. You could look at previous one [1] [2] but it is not
> necessary.
>
> The goal (still) is to improve performance by avoiding calling expensive
> functions when we don't need the information they provide
> or when we could get it by using a cheaper function.
>
> This patch is a middle step. In the end, I want to add new atoms
> ("objectsize:disk" and "deltabase") and reuse ref-filter logic in
> cat-file command.
>
> I also know about problems with memory leaks in ref-filter: that would
> be my next task that I will work on. Since I did not generate any new
> leaks in this patch (just use existing ones), I decided to put this
> part on a review and fix leaks as a separate task.

UPDATES since v1: add init to eaten variable (thanks to Szeder Gabor, Johannes Schindelin) improve second commit message (thanks to Junio C Hamano) add static keyword (thanks to Ramsay Jones)

Show 5 quoted lines

>
> Thank you!
>
> [1] https://github.com/git/git/pull/493
> [2] https://public-inbox.org/git/010201637254c969-a346030e-0b75-41ad-8ef3-2ac7e04ba4fb-000000@eu-west-1.amazonses.com/