Re: [PATCH] rebase -i: Fix white space in comments

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 26, 2018, 21:44 UTC
Message-ID: <nycvar.QRO.7.76.6.1806262343410.21419@tvgsbejvaqbjf.bet>
In-Reply-To: <nycvar.QRO.7.76.6.1806262331340.21419@tvgsbejvaqbjf.bet>

Hi, me again,

On Tue, 26 Jun 2018, Johannes Schindelin wrote:

Show 23 quoted lines

> On Tue, 26 Jun 2018, Johannes Schindelin wrote:
> 
> > On Tue, 26 Jun 2018, dana wrote:
> > 
> > > diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
> > > index 299ded213..a31af6d4c 100644
> > > --- a/git-rebase--interactive.sh
> > > +++ b/git-rebase--interactive.sh
> > > @@ -222,9 +222,9 @@ $comment_char $(eval_ngettext \
> > >  EOF
> > >  	append_todo_help
> > >  	gettext "
> > > -	However, if you remove everything, the rebase will be aborted.
> > > +However, if you remove everything, the rebase will be aborted.
> > >  
> > > -	" | git stripspace --comment-lines >>"$todo"
> > > +" | git stripspace --comment-lines >>"$todo"
> > >  
> > >  	if test -z "$keep_empty"
> > >  	then
> 
> This does the job, and I am fine with this way of doing things, and there
> seems to be a lot of precedent doing it this way e.g. in git-bisect.sh.

There is of course one other way to fix this, and that is by rewriting this in C.

Which Alban has done here ;-)

http://public-inbox.org/git/20180626161643.31152-3-alban.gruin@gmail.com

Ciao, Johannes