[PATCH] rebase -i: Fix white space in comments
- From
- dana <dana@dana.is>
- Date
- Jun 26, 2018, 18:02 UTC
- Message-ID
- <614F0C12-7173-48BD-9212-71AD6FBBDAA7@dana.is>
Fix a trivial white-space issue introduced by commit d48f97aa8 ("rebase: reindent function git_rebase__interactive", 2018-03-23). This affected the instructional comments displayed in the editor during an interactive rebase.
Signed-off-by: dana <dana@dana.is> ---
Sorry if i've done any of this wrong; i've never used this work-flow before. In any case, if it's not immediately obvious, this is the issue i mean to fix:
BEFORE (2.17.1):
# If you remove a line here THAT COMMIT WILL BE LOST. # # However, if you remove everything, the rebase will be aborted. # # Note that empty commits are commented out
AFTER (2.18.0):
# If you remove a line here THAT COMMIT WILL BE LOST. # # However, if you remove everything, the rebase will be aborted. # # # Note that empty commits are commented out
The 2.18.0 version is particularly irritating because many editors highlight the trailing tab in the penultimate line as a white-space error.
Aside: It's not a new thing, but i've always felt like that last line should end in a full stop. Maybe i'll send a patch for that too.
Cheers, dana
git-rebase--interactive.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh index 299ded213..a31af6d4c 100644 --- a/git-rebase--interactive.sh +++ b/git-rebase--interactive.sh @@ -222,9 +222,9 @@ $comment_char $(eval_ngettext \ EOF append_todo_help gettext " - However, if you remove everything, the rebase will be aborted. +However, if you remove everything, the rebase will be aborted. - " | git stripspace --comment-lines >>"$todo" +" | git stripspace --comment-lines >>"$todo" if test -z "$keep_empty" then
-- 2.18.0