Re: [PATCH] t3404: check root commit in 'rebase -i --root reword root commit'

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 20, 2018, 11:03 UTC
Message-ID: <nycvar.QRO.7.76.6.1806201301530.11870@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqin6ewyv2.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Tue, 19 Jun 2018, Junio C Hamano wrote:

Show 12 quoted lines

> Todd Zullinger <tmz@pobox.com> writes:
> 
> > With luck, this will save you a few minutes, assuming the
> > commit message is reasonable (or can be improved with help
> > from Phillip and others). :)
> 
> OK.
> 
> > Or Junio may just squash this onto js/rebase-i-root-fix.
> 
> Nah, not for a hotfix on the last couple of days before the final.
> We'd need to build on top, not "squash".

Right. Can we take this on top, at a leisurely pace? I mean: we verified that this works in the upcoming v2.18.0, and it would be nice to have that extra regression test safety in the future, but it is not crucial to include it in v2.18.0 itself.

Ciao, Dscho