Re: [PATCH 0/2] rebase --root: fix `reword` on a root commit

From: Todd Zullinger <tmz@pobox.com>
Date: Jun 16, 2018, 20:11 UTC
Message-ID: <20180616201143.GH11827@zaya.teonanacatl.net>
In-Reply-To: <pull.3.git.gitgitgadget@gmail.com>

Hi Johannes,

Johannes Schindelin via GitGitGadget wrote:

Show 10 quoted lines

> From: GitGitGadget <gitgitgadget@gmail.com>
> 
> Todd Zullinger reported this bug in
> https://public-inbox.org/git/20180615043111.GS3094@zaya.teonanacatl.net/:
> when calling git rebase --root and trying to reword the
> root commit's message, a BUG is reported.
>
> This fixes that.
> 
> IMO the bug fix is trivial enough to qualify for inclusion into v2.18.0, still.

It does indeed fix the issue. I agree it would be nice to see it in 2.18.0. As a fix for a minor regression introduced in this cycle, that seems reasonable.

Show 12 quoted lines

> Johannes Schindelin (1):
>   rebase --root: fix amending root commit messages
> 
> Todd Zullinger (1):
>   rebase --root: demonstrate a bug while amending root commit messages
> 
>  sequencer.c                   | 2 +-
>  t/t3404-rebase-interactive.sh | 9 +++++++++
>  2 files changed, 10 insertions(+), 1 deletion(-)
> 
> 
> base-commit: 68372c88794aba15f853542008cda39def768372

-- 
Todd
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
I don't mean to sound cold, or cruel, or vicious,
but I am, so that's the way it comes out.
    -- Bill Hicks