Re: [PATCH 5/5] merge-recursive: simplify handle_change_delete

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 21, 2018, 13:41 UTC
Message-ID: <nycvar.QRO.7.76.6.1805211540120.77@tvgsbejvaqbjf.bet>
In-Reply-To: <CABPp-BFjF7ZAjqi79aRbT+0M+stPnrcEXwYoV75qCHTb2oLiXg@mail.gmail.com>

Hi Elijah,

On Sat, 19 May 2018, Elijah Newren wrote:

Show 12 quoted lines

> On Sat, May 19, 2018 at 12:32 AM, Johannes Sixt <j6t@kdbg.org> wrote:
> > Am 19.05.2018 um 04:07 schrieb Elijah Newren:
> >>
> >> There is really no need for four branches of nearly identical messages
> >> when we can store the differences into small variables before printing.
> >
> > Oh, there is a reason for the repeated message text: translations! Please do
> > not play sentence Lego with translated strings. The original code is
> > preferable.
> 
> Ah, translations; that makes sense now.  I'm still annoyed by the
> code, but I retract patch 5 then.

Maybe you can remove the temptation for others, too, my replacing your patch 5 with one that adds the code comment "No sentence Lego! Think of our poor translators and refrain from making their life miserable!" or some more appropriate one?

Ciao, Dscho