Re: [PATCH 5/5] merge-recursive: simplify handle_change_delete
- From
Elijah Newren <newren@gmail.com>
- Date
- May 19, 2018, 15:39 UTC
- Message-ID
- <CABPp-BFjF7ZAjqi79aRbT+0M+stPnrcEXwYoV75qCHTb2oLiXg@mail.gmail.com>
- In-Reply-To
- <3b05f4b1-e236-989d-afe0-e85b28c2e278@kdbg.org>
On Sat, May 19, 2018 at 12:32 AM, Johannes Sixt <j6t@kdbg.org> wrote:
Show 8 quoted lines
> Am 19.05.2018 um 04:07 schrieb Elijah Newren: >> >> There is really no need for four branches of nearly identical messages >> when we can store the differences into small variables before printing. > > Oh, there is a reason for the repeated message text: translations! Please do > not play sentence Lego with translated strings. The original code is > preferable.
Ah, translations; that makes sense now. I'm still annoyed by the code, but I retract patch 5 then.