Re: [PATCH] fast-export: fix regression skipping some merge-commits

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Apr 20, 2018, 21:00 UTC
Message-ID: <nycvar.QRO.7.76.6.1804202258071.4241@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz>
In-Reply-To: <CAN0heSreFmd_0QnTjgYdpOZ8y7iNc3J+dYcpo5oKJBF2ff5-jQ@mail.gmail.com>

Hi Martin,

On Fri, 20 Apr 2018, Martin Ågren wrote:

> Thanks a lot for your comments. I will give this some testing, check
> that your proposed test fails and succeeds as it should, and so on, then
> try to wrap this up.

Thank you so much!

> Between you cleaning up the test and providing a different
> implementation, there's not much left for me to take credit for. Can I
> forge your From: and Signed-off-by: on this?

I disagree, all I did was to play a variation of your tune. You are the composer of this patch, you performed all the hard work (analysis, implementation & testing), and you deserve the credit.

It would please my ego a bit, of course, if you could add a "Helped-by: Dscho" line... ;-)

Ciao, Dscho