[PATCH v3] fast-export: fix regression skipping some merge-commits
- From
- Martin Ågren <martin.agren@gmail.com>
- Date
- Apr 20, 2018, 22:12 UTC
- Message-ID
- <20180420221231.4131611-1-martin.agren@gmail.com>
- In-Reply-To
- <nycvar.QRO.7.76.6.1804202258071.4241@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz>
7199203937 (object_array: add and use `object_array_pop()`, 2017-09-23) noted that the pattern `object = array.objects[--array.nr].item` could be abstracted as `object = object_array_pop(&array)`.
Unfortunately, one of the conversions was horribly wrong. Between grabbing the last object (i.e., peeking at it) and decreasing the object count, the original code would sometimes return early. The updated code on the other hand, will always pop the last element, then maybe do the early return without doing anything with the object.
The end result is that merge commits where all the parents have still not been exported will simply be dropped, meaning that they will be completely missing from the exported data.
Re-add a commit when it is not yet time to handle it. An alternative that was considered was to peek-then-pop. That carries some risk with it since the peeking and poping need to act on the same object, in a concerted fashion.
Add a test that would have caught this.
Reported-by: Isaac Chou <Isaac.Chou@microfocus.com> Analyzed-by: Isaac Chou <Isaac.Chou@microfocus.com> Helped-by: Johannes Schindelin <Johannes.Schindelin@gmx.de> Signed-off-by: Martin Ågren <martin.agren@gmail.com> --- This v3 is similar in spirit to v1/v2, but with a reworked test and a different fix approach, both based on Dscho's suggestions.
Show 7 quoted lines
>> Between you cleaning up the test and providing a different >> implementation, there's not much left for me to take credit for. Can I >> forge your From: and Signed-off-by: on this? > > I disagree, all I did was to play a variation of your tune. You are the > composer of this patch, you performed all the hard work (analysis, > implementation & testing), and you deserve the credit.
Ok.
> It would please my ego a bit, of course, if you could add a "Helped-by: > Dscho" line... ;-)
That's a given! Again, thanks for really helpful suggestions.
Martin
t/t9350-fast-export.sh | 18 ++++++++++++++++++ builtin/fast-export.c | 5 ++++- 2 files changed, 22 insertions(+), 1 deletion(-)
diff --git a/t/t9350-fast-export.sh b/t/t9350-fast-export.sh index 866ddf6058..c699c88d00 100755 --- a/t/t9350-fast-export.sh +++ b/t/t9350-fast-export.sh @@ -540,4 +540,22 @@ test_expect_success 'when using -C, do not declare copy when source of copy is a test_cmp expected actual ' +test_expect_success 'merge commit gets exported with --import-marks' ' + test_create_repo merging && + ( + cd merging && + test_commit initial && + git checkout -b topic && + test_commit on-topic && + git checkout master && + test_commit on-master && + test_tick && + git merge --no-ff -m Yeah topic && + + echo ":1 $(git rev-parse HEAD^^)" >marks && + git fast-export --import-marks=marks master >out && + grep Yeah out + ) +' + test_done diff --git a/builtin/fast-export.c b/builtin/fast-export.c index 27b2cc138e..7b8dfc5af1 100644 --- a/builtin/fast-export.c +++ b/builtin/fast-export.c @@ -651,8 +651,11 @@ static void handle_tail(struct object_array *commits, struct rev_info *revs, struct commit *commit; while (commits->nr) { commit = (struct commit *)object_array_pop(commits); - if (has_unshown_parent(commit)) + if (has_unshown_parent(commit)) { + /* Queue again, to be handled later */ + add_object_array(&commit->object, NULL, commits); return; + } handle_commit(commit, revs, paths_of_changed_objects); } }
-- 2.17.0