Re: [PATCH] config: Use parseopt.

From: Jakub Narebski <jnareb@gmail.com>
Date: Feb 14, 2009, 11:52 UTC
Message-ID: <m3skmhteuk.fsf@localhost.localdomain>
In-Reply-To: <1234577142-22965-1-git-send-email-felipe.contreras@gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

> Reorganizing the code to use parseopt as suggested by Johannes
> Schindelin.

[...]

Show 6 quoted lines

> -static const char git_config_set_usage[] =
> -"git config [ --global | --system | [ -f | --file ] config-file ] [ --bool | --int | --bool-or-int ] [ -z | --null ] [--get | --get-all | --get-regexp | --replace-all | --add | --unset | --unset-all] name [value [value_regex]] | --rename-section old_name new_name | --remove-section name | --list | --get-color var [default] | --get-colorbool name [stdout-is-tty] | --edit | -e ]";
> +static const char *const builtin_config_usage[] = {
> +	"git config [options]",
> +	NULL
> +};

Just asking: why this change?

> +	OPT_BOOLEAN('z', "null", &end_null, "end values with null character"),

Terminate and NUL.

-- 
Jakub Narebski
Poland
ShadeHawk on #git