Re: [PATCH] config: Use parseopt.

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Feb 14, 2009, 12:06 UTC
Message-ID: <94a0d4530902140406l5ccd79b6x964ad53b83079799@mail.gmail.com>
In-Reply-To: <m3skmhteuk.fsf@localhost.localdomain>

On Sat, Feb 14, 2009 at 1:52 PM, Jakub Narebski <jnareb@gmail.com> wrote:

Show 14 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> Reorganizing the code to use parseopt as suggested by Johannes
>> Schindelin.
>
> [...]
>> -static const char git_config_set_usage[] =
>> -"git config [ --global | --system | [ -f | --file ] config-file ] [ --bool | --int | --bool-or-int ] [ -z | --null ] [--get | --get-all | --get-regexp | --replace-all | --add | --unset | --unset-all] name [value [value_regex]] | --rename-section old_name new_name | --remove-section name | --list | --get-color var [default] | --get-colorbool name [stdout-is-tty] | --edit | -e ]";
>> +static const char *const builtin_config_usage[] = {
>> +     "git config [options]",
>> +     NULL
>> +};
>
> Just asking: why this change?

So it's easier to understand and maintain?

>> +     OPT_BOOLEAN('z', "null", &end_null, "end values with null character"),
>
> Terminate and NUL.

Ok. Junio already suggested that.

-- 
Felipe Contreras