Re: [PATCHv3] Updated patch series for providing mechanism to list available repositories

From: Jakub Narebski <jnareb@gmail.com>
Date: Jul 27, 2010, 09:02 UTC
Message-ID: <m3sk35l2n6.fsf@localhost.localdomain>
In-Reply-To: <AANLkTikG0e5dtGgMe03s=PpG793B-MkrGjdGa0LuZ5zH@mail.gmail.com>

Greg Brockman <gdb@MIT.EDU> writes:

Show 12 quoted lines

> > It would probably help if you re-send the entire thing again.
>
> Ok, will do so shortly.
> 
> > It also seems to have an unaddressed comment
> > (<7vlj96m4mc.fsf@alter.siamese.dyndns.org> from Junio).
>
> Yep, my patch series actually does incorporate that comment.  I didn't
> respond to that explicitly because I didn't want to spam the list, but
> in the future I'll be sure to respond to comments... I can imagine it
> makes things much easier for
> people-who-are-not-the-one-writing-the-patch to follow.

There are two possible solutions to providing comments about patch (I think they are covered in Documentation/SubmittingPatches).

First is reply to email like you would usually do, and below some delimiter, e.g. the "scissors" line i.e. '-- >8 --' put the patch itself. You might need to start it with 'Subject:' line if the title of the patch is different from the subject of email.

Second, which I think would be more appropriate in your situation, is to put comments about patch, for example how you did address the comments, and/or how the patch changed from previous version in the area between '---' delimiter line, and diffstat. See for example http://permalink.gmane.org/gmane.comp.version-control.git/151703

HTH

-- 
Jakub Narebski
Poland
ShadeHawk on #git