Re: [PATCHv3] Updated patch series for providing mechanism to list available repositories
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Jul 29, 2010, 00:33 UTC
- Message-ID
- <20100729003342.GC29156@dert.cs.uchicago.edu>
- In-Reply-To
- <AANLkTikaBoMOEGvLU8FL4Cvw4zBecXytvAnAYTS9GBa3@mail.gmail.com>
Greg Brockman wrote:
Show 8 quoted lines
> (Incidentally, I just noticed a segfault with > > $ unset HOME > $ su git -m -c "git-receive-pack '~'" > > that's probably worth fixing... if people don't think this is too > pedantic of a case to fix, I'll submit a patch for it in a later > series [I think the segfault comes from path.c:expand_user_path].)
Here’s a patch to save you time. :)
http://git.kernel.org/?p=git/git.git;a=commitdiff;h=79bf149
> Anyway, i'll revise my first patch to use HOME rather than getpw*.
From the getpwnam(3) man page it looks like that is best practice, anyway.
Cheers, Jonathan