git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC] gitweb: parse_commit_text encoding fix

From
Jakub Narebski <jnareb@gmail.com>
Date
Aug 1, 2009, 09:21 UTC
Message-ID
<m3r5vvris1.fsf@localhost.localdomain>
In-Reply-To
<1249115323-17974-1-git-send-email-zfuzesi@eaglet.hu>
Zoltán Füzesi <zfuzesi@eaglet.hu> writes:
> Call to_utf8 when parsing author and committer names, otherwise they
> will appear with bad encoding if they written by using
> chop_and_escape_str.
[re-wrapped]
> 
> Signed-off-by: Zoltán Füzesi <zfuzesi@eaglet.hu>
Thanks.
Still, I do wonder if it would be possible to simply do the following:
  -binmode STDOUT, ':utf8';
  +use open qw(:std :utf8);
...but it unfortunately doesn't work.  It was tried in
  http://thread.gmane.org/gmane.comp.version-control.git/87129/focus=87135

to_utf8() has at least (possible) fallback if it encounters characters outside of UTF-8 coding.

> -			$co{'author'} = $1;
> +			$co{'author'} = to_utf8($1);
-- 
Jakub Narebski

Git User's Survey 2009: 
http://tinyurl.com/GitSurvey2009
Previous: Zoltán FüzesiNext: Füzesi Zoltán
Message 2 of 8 in “gitweb: parse_commit_text encoding fix”
  1. gitweb: parse_commit_text encoding fixZoltán Füzesi, Aug 1, 2009
  2. Jakub NarebskiAug 1, 2009
  3. Füzesi ZoltánAug 1, 2009
  4. gitweb: parse_commit_text encoding fixZoltán Füzesi, Aug 2, 2009
  5. Junio C HamanoAug 4, 2009
  6. Zoltán FüzesiAug 6, 2009
  7. Jakub NarebskiAug 7, 2009
  8. Jakub NarebskiAug 7, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.