Re: [PATCH/RFC] gitweb: parse_commit_text encoding fix
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Aug 1, 2009, 09:21 UTC
- Message-ID
- <m3r5vvris1.fsf@localhost.localdomain>
- In-Reply-To
- <1249115323-17974-1-git-send-email-zfuzesi@eaglet.hu>
Zoltán Füzesi <zfuzesi@eaglet.hu> writes:
> Call to_utf8 when parsing author and committer names, otherwise they > will appear with bad encoding if they written by using > chop_and_escape_str.
[re-wrapped]
> > Signed-off-by: Zoltán Füzesi <zfuzesi@eaglet.hu>
Thanks.
Still, I do wonder if it would be possible to simply do the following:
-binmode STDOUT, ':utf8'; +use open qw(:std :utf8);
...but it unfortunately doesn't work. It was tried in http://thread.gmane.org/gmane.comp.version-control.git/87129/focus=87135
to_utf8() has at least (possible) fallback if it encounters characters outside of UTF-8 coding.
> - $co{'author'} = $1;
> + $co{'author'} = to_utf8($1);-- Jakub Narebski Git User's Survey 2009: http://tinyurl.com/GitSurvey2009