Re: [PATCH/RFC] gitweb: parse_commit_text encoding fix

From: Füzesi Zoltán <zfuzesi@eaglet.hu>
Date: Aug 1, 2009, 16:55 UTC
Message-ID: <9ab80d150908010955l3710c54bp9e2716570fd1d5ed@mail.gmail.com>
In-Reply-To: <m3r5vvris1.fsf@localhost.localdomain>

2009/8/1 Jakub Narebski <jnareb@gmail.com>:

Show 15 quoted lines

>
> Thanks.
>
>
> Still, I do wonder if it would be possible to simply do the following:
>
>  -binmode STDOUT, ':utf8';
>  +use open qw(:std :utf8);
>
> ...but it unfortunately doesn't work.  It was tried in
>  http://thread.gmane.org/gmane.comp.version-control.git/87129/focus=87135
>
> to_utf8() has at least (possible) fallback if it encounters characters
> outside of UTF-8 coding.
>

The following 2 changes in my patch are unnecessary, but please confirm (I'm not familiar with perl (yet)):

-                               $co{'author_name'}  = $1;
+                               $co{'author_name'}  = to_utf8($1);

-                               $co{'committer_name'}  = $1;
+                               $co{'committer_name'}  = to_utf8($1);

BR, Zé