git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add testcase for 'git cvsexportcommit -w $cvsdir ...' with relative $GIT_DIR

From
Jakub Narebski <jnareb@gmail.com>
Date
Feb 13, 2008, 09:26 UTC
Message-ID
<m3odalcill.fsf@localhost.localdomain>
In-Reply-To
<7vabm5s2xs.fsf@gitster.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 11 quoted lines
> Except that I'll reorder the patches so that
> 
>  (1) this test comes first, but with test_expect_failure instead;
> 
>  (2) then your earlier fix patch, but with a change that changes
>      the test_expect_failure to test_expect_success.
> 
> Thanks.
> 
> Perhaps it would be a good idea to require fix-up patches to
> always come with a test case to prevent future regression.

Perhaps we should add this hint to SubmittingPatches, on top of your additions? And to t/README?

-- 
Jakub Narebski
Poland
ShadeHawk on #git
Previous: Junio C Hamano
Message 8 of 8 in “Fix 'git cvsexportcommit -w $cvsdir ...' when used with relative $GIT_DIR”
  1. Fix 'git cvsexportcommit -w $cvsdir ...' when used with relative $GIT_DIRJohan Herland, Feb 11, 2008
  2. Junio C HamanoFeb 11, 2008
  3. Robin RosenbergFeb 11, 2008
  4. Fix 'git cvsexportcommit -w $cvsdir ...' when used with relative $GIT_DIRJohan Herland, Feb 11, 2008
  5. Robin RosenbergFeb 12, 2008
  6. Add testcase for 'git cvsexportcommit -w $cvsdir ...' with relative $GIT_DIRJohan Herland, Feb 13, 2008
  7. Junio C HamanoFeb 13, 2008
  8. Jakub NarebskiFeb 13, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.