Re: [PATCH] Add testcase for 'git cvsexportcommit -w $cvsdir ...' with relative $GIT_DIR

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 13, 2008, 07:58 UTC
Message-ID: <7vabm5s2xs.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <200802130411.22093.johan@herland.net>

Johan Herland <johan@herland.net> writes:

Show 10 quoted lines

> The testcase verifies that 'git cvsexportcommit' functions correctly when
> the '-w' option is used, and GIT_DIR is set to a relative path (e.g. '.').
>
> Signed-off-by: Johan Herland <johan@herland.net>
> ---
>
> On Tuesday 12 February 2008, Robin Rosenberg wrote:
>> Looks ok. Something for the test suite?
>
> Like this?

Yeah, looks good.

Except that I'll reorder the patches so that

 (1) this test comes first, but with test_expect_failure instead;

 (2) then your earlier fix patch, but with a change that changes
     the test_expect_failure to test_expect_success.

Thanks.

Perhaps it would be a good idea to require fix-up patches to always come with a test case to prevent future regression.