Re: Commit f5bbc322 to git broke pre-commit hooks which read stdin

From: Jakub Narebski <jnareb@gmail.com>
Date: Mar 4, 2008, 11:51 UTC
Message-ID: <m3k5kiiu60.fsf@localhost.localdomain>
In-Reply-To: <alpine.LSU.1.00.0803041044120.22527@racer.site>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 15 quoted lines

> On Tue, 4 Mar 2008, David Bremner wrote:
> 
>> It looks like line 435 of builtin-commit.c disables stdin for hooks 
>> (with the disclaimer that I first looked at the git source ten minutes 
>> ago).
>> 
>> 	   hook.no_stdin = 1
>> 
>> I'm not sure if this was by design, but just so you know, this breaks 
>> people's hooks.  In particular the default metastore pre-commit hook no 
>> longer works.  I didn't find anything relevant in the docs [1].
> 
> Pardon my ignorance, but what business has metastore reading stdin?  There 
> should be nothing coming in, so the change you mentioned should be 
> correct, and your hook relies on something it should not rely on.

Never mind pre-commit. What about pre-receive and post-receive hooks, both of which gets data on stdin?

-- 
Jakub Narebski
Poland
ShadeHawk on #git