git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Commit f5bbc322 to git broke pre-commit hooks which read stdin

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Mar 4, 2008, 12:03 UTC
Message-ID
<alpine.LSU.1.00.0803041202150.22527@racer.site>
In-Reply-To
<m3k5kiiu60.fsf@localhost.localdomain>
Hi,
On Tue, 4 Mar 2008, Jakub Narebski wrote:
Show 11 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> > On Tue, 4 Mar 2008, David Bremner wrote:
> > 
> >> It looks like line 435 of builtin-commit.c disables stdin for hooks 
> >> (with the disclaimer that I first looked at the git source ten minutes 
> >> ago).
> >> 
> >> 	   hook.no_stdin = 1
> 
> Never mind pre-commit. What about pre-receive and post-receive hooks, 
> both of which gets data on stdin?

He was talking about builtin-commit.c. AFAIR there is no code to call pre-receive or post-receive in that file. ;-)

IOW the issue does not apply to the hooks you mentioned.

Ciao, Dscho

Previous: Jakub Narebski
Message 14 of 14 in “Bug#469250: Commit f5bbc322 to git broke pre-commit hooks which read stdin”
  1. David BremnerMar 4, 2008
  2. Johannes SchindelinMar 4, 2008
  3. Junio C HamanoMar 4, 2008
  4. Johannes SixtMar 4, 2008
  5. Junio C HamanoMar 4, 2008
  6. David BremnerMar 4, 2008
  7. Johannes SchindelinMar 4, 2008
  8. Joey HessMar 4, 2008
  9. David BremnerMar 4, 2008
  10. Shawn O. PearceMar 5, 2008
  11. Junio C HamanoMar 5, 2008
  12. Shawn O. PearceMar 5, 2008
  13. Jakub NarebskiMar 4, 2008
  14. Johannes SchindelinMar 4, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.