Re: Bug: "git checkout -b" should be allowed in empty repo
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Jan 31, 2012, 10:09 UTC
- Message-ID
- <m3k448che9.fsf@localhost.localdomain>
- In-Reply-To
- <4F27ACED.2050709@alum.mit.edu>
Michael Haggerty <mhagger@alum.mit.edu> writes:
Show 25 quoted lines
> On 01/30/2012 07:48 PM, Junio C Hamano wrote:
>> Michael Haggerty <mhagger@alum.mit.edu> writes:
>>
>>> [3] If commit 0000000 were treated specially, then there would be no
>>> unborn branches but only branches pointing at the empty commit. In that
>>> case, my expectation would change--the old branch should be left
>>> pointing at 0000000. But currently git has no concept of an unborn
>>> branch that is not HEAD.
>>
>> And it probably is not a good thing to add such. Under that constraints,
>> HEAD that says refs/heads/foo where foo does not exist yet needs to be
>> special cased at places where it matters.
>>
>> For that matter, even if we artificially created refs/heads/foo before any
>> commit is made and made it point at 0{40}, you would need to add special
>> cases to other parts of the system
>
> No, the idea is to avoid special casing by making 0{40} into a real (but
> empty) revision.
>
>> (e.g. "commit" needs to notice that the
>> result should be a root, not a child of 0{40};
>
> No, commits that were previously generated as orphans *would* now be
> generated as children of the special 0{40} commit.You would still have to have quite a bit of special cases about 0{40}
NUL commit. Perhaps less special cases, but new special cases.
[...]Show 6 quoted lines
>> so it does not change the fact that the unborn branch is case >> is special. > > On the contrary, I believe that much special casing could be eliminated > and the UI made more uniform by treating everything as a descendant of a > special "NULL" commit.
I don't see how this can be done in backward-compatibile way.
Please note that in Git it is quite natural to have more than one root (parentless) commit, even without presence of disconnected / orphan branches. They are result of joining originally separate projects. git.git has quite a few of them (more than 6, IIRC).
-- Jakub Narebski