Re: [PATCH] branch --edit-description: protect against mistyped branch name

From: Jeff King <peff@peff.net>
Date: Feb 6, 2012, 04:20 UTC
Message-ID: <20120206042043.GC29365@sigill.intra.peff.net>
In-Reply-To: <7vaa4wda60.fsf_-_@alter.siamese.dyndns.org>

On Sun, Feb 05, 2012 at 05:26:31PM -0800, Junio C Hamano wrote:

Show 10 quoted lines

> This incidentally also errors out --edit-description when the HEAD points
> at an unborn branch (immediately after "init", or "checkout --orphan"),
> because at that point, you do not even have any commit that is part of
> your history and there is no point in describing how this particular
> branch is different from the branch it forked off of, which is the useful
> bit of information the branch description is designed to capture.
> 
> We may want to special case the unborn case later, but that is outside the
> scope of this patch to prevent more common mistakes before 1.7.9 series
> gains too much widespread use.

That sounds OK to me. I'm not even sure people will want to use "--edit-description" on an unborn pointed-to branch or not (I mentioned it only as "this is a plausible use case to me that we might be breaking"). I think people will still be figuring out workflows around it. So it's not a big deal to wait and see.

-Peff