Re: [PATCH] gitweb: Identify all summary metadata table rows

From: Jakub Narebski <jnareb@gmail.com>
Date: Oct 3, 2008, 01:04 UTC
Message-ID: <m3hc7uqyix.fsf@localhost.localdomain>
In-Reply-To: <20081003003053.GT21310@spearce.org>

"Shawn O. Pearce" <spearce@spearce.org> writes:

> Petr Baudis <pasky@suse.cz> wrote:

Show 10 quoted lines

> > In the metadata table of the summary page, all rows have their
> > id (or class in case of URL) set now. This for example lets sites
> > easily disable fields they do not want to show in their custom
> > stylesheet (e.g. they are overly technical or irrelevant for the site).
> > 
> > Many of my other patches depend on this, so I would appreciate to hear
> > as soon as possible if someone has an issue with this patch.
> 
> Its pretty trivial and painless.  So its applied.  Marking up unique
> elements so you can control them via CSS isn't rocket science.  ;-)

Somehow original patch didn't appear (yet) on git mailing list;
perhaps it ran afoul vger anti-SPAM filter...

> > +	      "<tr id=\"metadata_desc\"><td>description</td><td>" . esc_html($descr) . "</td></tr>\n" .
> > +	      "<tr id=\"metadata_owner\"><td>owner</td><td>" . esc_html($owner) . "</td></tr>\n";
> > +		print "<tr id=\"metadata_lchange\"><td>last change</td><td>$cd{'rfc2822'}</td></tr>\n";
> > +		print "<tr class=\"metadata_url\"><td>$url_tag</td><td>$git_url</td></tr>\n";

I like the idea, and I think this can be seen as beginning to use either microformats, or RDFa. You have marked those fragments for CSS to show or hide; microformats are about marking those fragments for machine to parse. Although microformats usually use 'class' (or 'rel' for links), not 'id' attribute for classifying data...

-- 
Jakub Narebski
Poland
ShadeHawk on #git