Re: [PATCH] gitweb: Identify all summary metadata table rows
Petr Baudis <pasky@suse.cz> wrote:
Show 7 quoted lines
> In the metadata table of the summary page, all rows have their
> id (or class in case of URL) set now. This for example lets sites
> easily disable fields they do not want to show in their custom
> stylesheet (e.g. they are overly technical or irrelevant for the site).
>
> Many of my other patches depend on this, so I would appreciate to hear
> as soon as possible if someone has an issue with this patch.
Its pretty trivial and painless. So its applied. Marking up unique
elements so you can control them via CSS isn't rocket science. ;-)
Show 27 quoted lines
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index da474d0..bd8124a 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -4070,10 +4070,10 @@ sub git_summary {
>
> print "<div class=\"title\"> </div>\n";
> print "<table class=\"projects_list\">\n" .
> - "<tr><td>description</td><td>" . esc_html($descr) . "</td></tr>\n" .
> - "<tr><td>owner</td><td>" . esc_html($owner) . "</td></tr>\n";
> + "<tr id=\"metadata_desc\"><td>description</td><td>" . esc_html($descr) . "</td></tr>\n" .
> + "<tr id=\"metadata_owner\"><td>owner</td><td>" . esc_html($owner) . "</td></tr>\n";
> if (defined $cd{'rfc2822'}) {
> - print "<tr><td>last change</td><td>$cd{'rfc2822'}</td></tr>\n";
> + print "<tr id=\"metadata_lchange\"><td>last change</td><td>$cd{'rfc2822'}</td></tr>\n";
> }
>
> # use per project git URL list in $projectroot/$project/cloneurl
> @@ -4083,7 +4083,7 @@ sub git_summary {
> @url_list = map { "$_/$project" } @git_base_url_list unless @url_list;
> foreach my $git_url (@url_list) {
> next unless $git_url;
> - print "<tr><td>$url_tag</td><td>$git_url</td></tr>\n";
> + print "<tr class=\"metadata_url\"><td>$url_tag</td><td>$git_url</td></tr>\n";
> $url_tag = "";
> }
> print "</table>\n";--
Shawn.
Shawn O. Pearce <spearce@spearce.org>