Re: [PATCH v2 5/6] run test suite without dashed git-commands in PATH
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Dec 1, 2009, 17:24 UTC
- Message-ID
- <m3fx7un7vb.fsf@localhost.localdomain>
- In-Reply-To
- <1259561971-25730-6-git-send-email-mmogilvi_git@miniinfo.net>
Matthew Ogilvie <mmogilvi_git@miniinfo.net> writes:
Show 16 quoted lines
> diff --git a/t/README b/t/README > index 4e1d7dd..8c5d892 100644 > --- a/t/README > +++ b/t/README > @@ -75,6 +75,14 @@ appropriately before running "make". > As the names depend on the tests' file names, it is safe to > run the tests with this option in parallel. > > +--with-dashes:: > + By default tests are run without dashed forms of > + commands (like git-commit) in the PATH (it only uses > + wrappers from TOP/git-bin). Use this option to include TOP > + in the PATH, which conains all the dashed forms of commands. > + This option is currently implied by other options like --valgrind > + and GIT_TEST_INSTALLED. > +
Shouldn't it be 'TOP/bin-wrappers' and not 'TOP/git-bin'? Shouldn't TOP be explained somewhere, or is it obvious in the context?
s/conains/contains/.
> +else # normal case, use ../bin-wrappers only unless $with_dashes:
-- Jakub Narebski Poland ShadeHawk on #git