git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 5/6] run test suite without dashed git-commands in PATH

From
Jakub Narebski <jnareb@gmail.com>
Date
Dec 1, 2009, 17:24 UTC
Message-ID
<m3fx7un7vb.fsf@localhost.localdomain>
In-Reply-To
<1259561971-25730-6-git-send-email-mmogilvi_git@miniinfo.net>
Matthew Ogilvie <mmogilvi_git@miniinfo.net> writes:
Show 16 quoted lines
> diff --git a/t/README b/t/README
> index 4e1d7dd..8c5d892 100644
> --- a/t/README
> +++ b/t/README
> @@ -75,6 +75,14 @@ appropriately before running "make".
>  	As the names depend on the tests' file names, it is safe to
>  	run the tests with this option in parallel.
>  
> +--with-dashes::
> +	By default tests are run without dashed forms of
> +	commands (like git-commit) in the PATH (it only uses
> +	wrappers from TOP/git-bin).  Use this option to include TOP
> +	in the PATH, which conains all the dashed forms of commands.
> +	This option is currently implied by other options like --valgrind
> +	and GIT_TEST_INSTALLED.
> +

Shouldn't it be 'TOP/bin-wrappers' and not 'TOP/git-bin'? Shouldn't TOP be explained somewhere, or is it obvious in the context?

s/conains/contains/.
> +else # normal case, use ../bin-wrappers only unless $with_dashes:
-- 
Jakub Narebski
Poland
ShadeHawk on #git
Previous: Junio C HamanoNext: Matthew Ogilvie
Message 9 of 14 in “Run test suite without dashed commands in PATH”
  1. 0/6 Run test suite without dashed commands in PATHMatthew Ogilvie, Nov 30, 2009
  2. 1/6 t2300: use documented technique to invoke git-sh-setupMatthew Ogilvie, Nov 30, 2009
  3. 2/6 t3409 t4107 t7406: use dashless commandsMatthew Ogilvie, Nov 30, 2009
  4. 3/6 t/README: Document GIT_TEST_INSTALLED and GIT_TEST_EXEC_PATHMatthew Ogilvie, Nov 30, 2009
  5. 4/6 build dashless "bin-wrappers" directory similar to installed bindirMatthew Ogilvie, Nov 30, 2009
  6. 5/6 run test suite without dashed git-commands in PATHMatthew Ogilvie, Nov 30, 2009
  7. 6/6 INSTALL: document a simpler way to run uninstalled buildsMatthew Ogilvie, Nov 30, 2009
  8. Junio C HamanoNov 30, 2009
  9. Jakub NarebskiDec 1, 2009
  10. Matthew OgilvieDec 2, 2009
  11. Junio C HamanoDec 2, 2009
  12. Junio C HamanoNov 30, 2009
  13. Matthew OgilvieDec 1, 2009
  14. Junio C HamanoNov 30, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.