[PATCH v2 0/6] Run test suite without dashed commands in PATH
- From
- Matthew Ogilvie <mmogilvi_git@miniinfo.net>
- Date
- Nov 30, 2009, 06:19 UTC
- Message-ID
- <1259561971-25730-1-git-send-email-mmogilvi_git@miniinfo.net>
This patch series runs the test suite without the dashed commands in the PATH.
Changes since version 1:
- Added patch 3 that documents the pre-existing GIT_TEST_INSTALLED
feature. - Rename what used to be "test-bin" directory as "bin-wrappers", to
more clearly describe what it is. - Split off patch 6 (INSTALL documention) from patch
4 (was patch 3), describing how the bin-wrappers directory
is a very convenient way to manually test an uninstalled build.
I also reworded it a bit to mention the downsides. Junio
doesn't seem to agree this is useful; splitting it off makes
it easy to leave it out.Not changed:
There was some discussion about not building the bin-wrappers directory unless you are actually running tests. But I don't really think it is worth the additional complexity to manage this. The "make all" target is already building several full-up binaries to support the test suite (not just the small sed-ed scripts that this adds). And any such solution would need to deal with parallel execution locking issues, as well as additional uglyness (either duplicating a list of bindir executables within test-lib.sh itself, or calling into a parent directory makefile that might already be running in a grandparent process).
Matthew Ogilvie (6): t2300: use documented technique to invoke git-sh-setup t3409 t4107 t7406: use dashless commands t/README: Document GIT_TEST_INSTALLED and GIT_TEST_EXEC_PATH build dashless "bin-wrappers" directory similar to installed bindir run test suite without dashed git-commands in PATH INSTALL: document a simpler way to run uninstalled builds
.gitignore | 1 + INSTALL | 11 +++++++- Makefile | 49 ++++++++++++++++++++++++++--------- t/README | 21 +++++++++++++++ t/t2300-cd-to-toplevel.sh | 2 +- t/t3409-rebase-preserve-merges.sh | 6 ++-- t/t4107-apply-ignore-whitespace.sh | 20 +++++++------- t/t7406-submodule-update.sh | 4 +- t/test-lib.sh | 33 +++++++++++++++--------- wrap-for-bin.sh | 15 +++++++++++ 10 files changed, 120 insertions(+), 42 deletions(-) create mode 100644 wrap-for-bin.sh