Re: RFC: [PATCH] ignore SIGINT&QUIT while waiting for external command

From: Jakub Narebski <jnareb@gmail.com>
Date: Oct 19, 2010, 21:06 UTC
Message-ID: <m3fww1lwqw.fsf@localhost.localdomain>
In-Reply-To: <20101019191638.GI25139@burratino>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 7 quoted lines

> -	sigchain_push(SIGINT, SIG_IGN);
> -	sigchain_push(SIGQUIT, SIG_IGN);
> +	if (the_child)
> +		die("What?  _Two_ children?");
> +	the_child = cmd;
> +	sigchain_push(SIGINT, interrupted_with_child);
> +	sigchain_push(SIGQUIT, interrupted_with_child);

Please, don't do this. It is almost as bad as error message as "You don't exist. Go away".

-- 
Jakub Narebski
Poland
ShadeHawk on #git