Re: RFC: [PATCH] ignore SIGINT&QUIT while waiting for external command
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Oct 19, 2010, 21:07 UTC
- Message-ID
- <20101019210753.GB32029@burratino>
- In-Reply-To
- <m3fww1lwqw.fsf@localhost.localdomain>
Jakub Narebski wrote:
> Jonathan Nieder <jrnieder@gmail.com> writes:
Show 10 quoted lines
>> - sigchain_push(SIGINT, SIG_IGN);
>> - sigchain_push(SIGQUIT, SIG_IGN);
>> + if (the_child)
>> + die("What? _Two_ children?");
>> + the_child = cmd;
>> + sigchain_push(SIGINT, interrupted_with_child);
>> + sigchain_push(SIGQUIT, interrupted_with_child);
>
> Please, don't do this. It is almost as bad as error message as
> "You don't exist. Go away".Hopefully it was clear that the behavior (erroring out) is as unacceptable as the message.