Re: [RFC/PATCH 1/4] Add git-sequencer shell prototype
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Jul 3, 2008, 13:10 UTC
- Message-ID
- <m3d4lvf70w.fsf@localhost.localdomain>
- In-Reply-To
- <1214879914-17866-2-git-send-email-s-beyer@gmx.net>
Stephan Beyer <s-beyer@gmx.net> writes:
Show 5 quoted lines
> +# Generate message, patch and author script files
> +make_patch () {
> + parent_sha1=$(git rev-parse --verify "$1"^) ||
> + die "Cannot get patch for $1^"
> + git diff-tree -p "$parent_sha1..$1" >"$PATCH"First, let's not perpetuate _convenience_ calling convention of "A..B" of git-diff* family, but use "A B" to set _endpoints_.
Second, with "A B" convention you can fairly easy deal with root commit, changing the code to the fragment below:
+# Generate message, patch and author script files +make_patch () { + parent_sha1=$(git rev-parse --verify "$1"^) || + echo '--root' + git diff-tree -p "$parent_sha1" "$1" >"$PATCH"
BTW. what is best way of checking if given revision is parent-less?
-- Jakub Narebski Poland ShadeHawk on #git