Re: [PATCH 2/3] gitweb: decorate a bit more remotes

From: Jakub Narebski <jnareb@gmail.com>
Date: Dec 20, 2010, 23:11 UTC
Message-ID: <m3d3owkplq.fsf@localhost.localdomain>
In-Reply-To: <1292871681-4818-3-git-send-email-sylvain@abstraction.fr>

Sylvain Rabot <sylvain@abstraction.fr> writes:

> -			$urls_table .= format_repo_url("URL", $fetch);
> +			$urls_table .= format_repo_url("<span class=\"bold\">URL:</span>", $fetch);

[...]

Show 11 quoted lines

> diff --git a/gitweb/static/gitweb.css b/gitweb/static/gitweb.css
> index 79d7eeb..ce902f5 100644
> --- a/gitweb/static/gitweb.css
> +++ b/gitweb/static/gitweb.css
> @@ -579,6 +579,10 @@ div.remote {
>  	display: inline-block;
>  }
>  
> +.bold {
> +	font-weight: bold;
> +}

<span class="bold"> is not much different from <strong> or <b>; I'd rather you use some semantic name for the class, describing what content it contains rather than what style it uses.

-- 
Jakub Narebski
Poland
ShadeHawk on #git