Re: [PATCH 3/3] {fetch,upload}-pack: allow --depth=0 to deepen into full repo again

From: Jakub Narebski <jnareb@gmail.com>
Date: Aug 19, 2010, 21:22 UTC
Message-ID: <m362z6pact.fsf@localhost.localdomain>
In-Reply-To: <1282214437-16384-3-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

Show 10 quoted lines

> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
>  The funny thing is, even with --depth=0, I still have two commit grafts
>  in $GIT_DIR/shallow, which are grafts of tags. I think there is a bug somewhere..
> 
>  builtin/fetch-pack.c |    2 +-
>  shallow.c            |    2 +-
>  upload-pack.c        |    8 ++++----
>  3 files changed, 6 insertions(+), 6 deletions(-)
>

Fist, it lacks documentation update that --depth=0 means infinite depth (making repository not-shallow).

Second, it would be nice (though probably not easy with parseopt, as it would require hacks/extensions) to be able to use --depth=inf (like wget supports '-l inf') to mean infinite depth...

-- 
Jakub Narebski
Poland
ShadeHawk on #git