Re: [PATCH 3/3] {fetch,upload}-pack: allow --depth=0 to deepen into full repo again
- From
Ramkumar Ramachandra <artagnon@gmail.com>
- Date
- Aug 20, 2010, 09:28 UTC
- Message-ID
- <20100820092847.GF12794@kytes>
- In-Reply-To
- <201008201122.09392.jnareb@gmail.com>
Hi Jakub,
Jakub Narebski writes:
Show 18 quoted lines
> >> Second, it would be nice (though probably not easy with parseopt, as > >> it would require hacks/extensions) to be able to use --depth=inf > >> (like wget supports '-l inf') to mean infinite depth... > > > > Hmm.. make --depth a string parameter and fetch-pack should parse the > > parameter itself, like git-clone. Good idea. > > If there were more options that use <n> == 0 to actually mean unlimited > (infinity), perhaps it would be better to extend parseopt to provide for > such situation, e.g. OPT_INT_INF or something. This way we would avoid > code duplication. > > ... oh, wait, the newly introduced[1] git-merge `--log-limit' option > uses --log-limit=0 to mean unlimited. > > [1] http://permalink.gmane.org/gmane.comp.version-control.git/153984 > Message-ID: <20100820081641.GA32127@burratino> > Subject: Re: wishlist bugreport: make limit configurable for do_fmt_merge_msg (merge.log)
Just outdated by a few seconds. Johannes suggested that we reuse merge.log, making it a bool_or_int option. I What about using -1 to mean infinity and reserving 0 for false instead?
-- Ram