Re: [PATCH v2 00/14] Sparse checkout

From: Jakub Narebski <jnareb@gmail.com>
Date: Sep 20, 2008, 16:45 UTC
Message-ID: <m31vzen4v5.fsf@localhost.localdomain>
In-Reply-To: <1221904913-25887-1-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:

> Main changes from the last round are:
>  - The name is now "sparse checkout"

I guess that 'sparse checkout' would be more recognizable than 'narrow checkout'.

>  - "git clone --path" => "git clone --narrow-path"
>  - "git checkout --path" => "git checkout --reset-path"

I am not sure about that change, especially the fact that git-clone and git-checkout use differently named options, because those options affect clone only as they affect the checkout part of the clone. One would think that git-clone = git-init + git-remote add + git-fetch + git-checkout, and that git-clone would simply pass sparse checkout flags to git-checkout.

>  - New narrow spec (or "sparse patterns" from now) resembles
>    .gitignore patterns

You mean here that rules for patterns to select which parts of tree mark as "no-checkout" and/or checkout/leave in checkout are the same (or nearly the same) as rules for ignoring files, isn't it?

BTW I think that the same rules are used in gitattributes, aren't they?

>  - "git ls-files" now supports more fine-grained listing. It can now
>    list checkout files, no-checkout files or orphaned (previously
>    "overlay") files. --overlay is gone

Good. I hope (I haven't read the post yet) that you extended '-t' and '-v' output (or added similar option for no-checkout bit specially) for git-ls-files.

>  - "git status" shows orphaned entries and remedies

Good. I guess (I haven't read the post yet) that git-status displays, or can be asked to display "orphaned"/"unwanted" files (files which exists in working repository, but are marked with "no-checkout" bit), and perhaps simply the fact that we commit/are in narrow checkout (there is at least one file with "no-checkout" bit set in the index).

> For code changes, significant changes are:

>   [10/14] ls-files: support "sparse patterns", used to form sparse
>           checkout areas

Hmmm...

> I hope I have addressed all the issues. If I miss anything, please
> speak up.

 
By the way, pleas do not worry if there would be new round of
comments.  Sparse checkout is a new feature, and I think it is quite
important to get UI (interface) part, like names of configuration
variables and options first, or at least correct them before sparse
checkout hits released version.  It is harder IMVHO to change user
interface (this applies also to non-local repository data) due to
concerns for backwards compatibility; it is I think easier to correct
code.

> Nguyá»n ThÃ¡i Ngá»c Duy (14):

Errr... what happened here? For me it doesn't look like correct UTF-8 encoding, but perhaps that it is just my news client (Gnus)...

P.S. Thanks for numbering this series.

-- 
Jakub Narebski
Poland
ShadeHawk on #git