Re: [PATCH 01/14] Extend index to save more flags
- From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
- Date
- Sep 21, 2008, 04:34 UTC
- Message-ID
- <fcaeb9bf0809202134p2457e0cdn50ae8183ba07bcde@mail.gmail.com>
- In-Reply-To
- <m3skrulbrd.fsf@localhost.localdomain>
On 9/21/08, Jakub Narebski <jnareb@gmail.com> wrote:
Show 16 quoted lines
> > + > > +#define CE_EXTENDED_FLAGS (0) > > + > > +/* > > + * Safeguard to avoid saving wrong flags: > > + * - CE_EXTENDED2 won't get saved until its semantic is known > > + * - Bits in 0x0000FFFF have been saved in ce_flags already > > + * - Bits in 0x003F0000 are currently in-memory flags > > + */ > > +#if CE_EXTENDED_FLAGS & 0x80CFFFFF > > +#error "CE_EXTENDED_FLAGS out of range" > > +#endif > > > I don't quite understand the above fragment (especially with the fact > that CE_EXTENDED_FLAGS is defined as (0))...
Because this patch does not introduce any new on-disk flag yet so CE_EXTENDED_FLAGS remains 0. In the next patch, CE_EXTENDED_FLAGS will be updated to have CE_NO_CHECKOUT.
-- Duy