Re: [PATCH] git-cherry.txt: Change symbol marks in graph.
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Dec 2, 2010, 08:00 UTC
- Message-ID
- <m31v604nc0.fsf@localhost.localdomain>
- In-Reply-To
- <1291267093-29855-1-git-send-email-jari.aalto@cante.net>
Jari Aalto <jari.aalto@cante.net> writes:
Show 9 quoted lines
> From: Jari Aalto <jari.aalto@cante.net> > > The common commit were marked with a minus sign (-), but that is > usually interpreted as something less or substracted. Use natural > equal sign (=). Commits that are not in upstream were marked with plus > sign (+) but a question mark (?) is visually a litle more striking > (erect) in context where all other signs are "flat". It also helps > visually impared to see difference between (* ... ?) as opposed to > similar signs (* ... +).
Reading comprehension FAIL. The graph in question uses '+' and '-' because that is what 'git cherry' *output( uses ('+' included, '-' excluded). They are very natural in git-cherry output (diff-like).
-- Jakub Narebski Poland ShadeHawk on #git